Add GetDefaultTarget and SetDefaultTarget APIs #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
force-pushed
the
set-get-default-target
branch
4 times, most recently
from
1327559
to
d1c0dab
Compare
ArtiomDivak
force-pushed
the
set-get-default-target
branch
3 times, most recently
from
d7b39b3
to
ef50d6d
Compare
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
mwperina
reviewed
Oct 2, 2024
tests/tests/tier0/bluechi-get-default-target/test_bluechi_agent_get_default_target.py
Outdated
Show resolved
Hide resolved
mwperina
changed the title
|
Also please don't forget to update bluechictl man page: https://github.com/eclipse-bluechi/bluechi/blob/main/doc/man/bluechictl.1.md |
ArtiomDivak
force-pushed
the
set-get-default-target
branch
4 times, most recently
from
2e008ad
to
4b970c2
Compare
mwperina
reviewed
Oct 3, 2024
mwperina
reviewed
Oct 3, 2024
mwperina
reviewed
Oct 3, 2024
tests/tests/tier0/bluechictl-set-get-default-target/test_bluechictl_set_get_deault_target.py
Outdated
Show resolved
Hide resolved
mwperina
reviewed
Oct 3, 2024
tests/tests/tier0/bluechictl-set-get-default-target/test_bluechictl_set_get_deault_target.py
Outdated
Show resolved
Hide resolved
mwperina
reviewed
Oct 3, 2024
tests/tests/tier0/bluechictl-set-get-default-target/test_bluechictl_set_get_deault_target.py
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
set-get-default-target
branch
from
4b970c2
to
7e28ac4
Compare
mwperina
reviewed
Oct 3, 2024
ArtiomDivak
force-pushed
the
set-get-default-target
branch
2 times, most recently
from
68a974d
to
b7f51c8
Compare
mwperina
requested changes
Oct 4, 2024
tests/tests/tier0/bluechictl-set-get-default-target/test_bluechictl_set_get_default_target.py
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
set-get-default-target
branch
5 times, most recently
from
863766d
to
607f4a5
Compare
mkemel
reviewed
Oct 6, 2024
ArtiomDivak
force-pushed
the
set-get-default-target
branch
2 times, most recently
from
be1c18a
to
a39d66e
Compare
mwperina
requested changes
Oct 7, 2024
tests/tests/tier0/bluechictl-set-get-default-target/test_bluechictl_set_get_default_target.py
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
set-get-default-target
branch
6 times, most recently
from
d4967b4
to
f6bbdb6
Compare
This feature will get and set the default target for a specific node. Solves eclipse-bluechi#944 Signed-off-by: Artiom Divak <[email protected]>
ArtiomDivak
force-pushed
the
set-get-default-target
branch
from
f6bbdb6
to
d974d1d
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #944
Signed-off-by: Artiom Divak [email protected]